sidski/Cinemateket
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

🥅 handled input errors in API

Browse source 
Co-authored-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
This commit is contained in:
haraldnilsen 2023-09-19 13:45:34 +02:00
parent 4f063495f2
commit 983a6af41a
1 changed files with 20 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

27
backend/Controllers/MovieController.cs
View file

@ -1,7 +1,8 @@
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
using Microsoft.OpenApi.Writers; using Microsoft.OpenApi.Writers;
namespace backend.Controllers; namespace backend;
using static backend.QueryParameterValidators;
[ApiController] [ApiController]
[Route("[controller]")] [Route("[controller]")]
@ -9,6 +10,10 @@ public class MovieController: ControllerBase
{ {
private readonly MovieDbContext _context; private readonly MovieDbContext _context;
private readonly ILogger<MovieController> _logger; private readonly ILogger<MovieController> _logger;
private static readonly string[] sortTypes = new[]
{
"titleasc", "titledesc", "yearasc", "yeardesc"
};
public MovieController(ILogger<MovieController> logger, MovieDbContext context) public MovieController(ILogger<MovieController> logger, MovieDbContext context)
{ {
@ -18,31 +23,39 @@ public class MovieController: ControllerBase
[HttpGet(Name = "GetMovies")] [HttpGet(Name = "GetMovies")]
public ActionResult<IEnumerable<MovieDB>> Get( public ActionResult<IEnumerable<MovieDB>> Get(
[FromQuery] string? s, [FromQuery] string s,
[FromQuery] string? type, [FromQuery] string? type,
[FromQuery] string? y, [FromQuery] string? y,
[FromQuery] string? sort,
[FromQuery] int pageNumber = 1, [FromQuery] int pageNumber = 1,
[FromQuery] int pageSize = 5 [FromQuery] int pageSize = 5
) { ) {
try try
{ {
if (s == "") { if (IsValidS(s)) return StatusCode(400, "Bad Request: Invalid title");
return StatusCode(400, "Bad Request");
}
var movies = _context.Movies.Where(m => m.Title.Contains(s.ToLower())); var movies = _context.Movies.Where(m => m.Title.Contains(s.ToLower()));
if (type != null) { if (type != null) {
if (!IsValidType(type)) return StatusCode(400, "Bad Request: Invalid type");
movies = movies.Where(m => m.Type == type); movies = movies.Where(m => m.Type == type);
} }
if (y != null) { if (y != null) {
if (!IsValidYear(y)) return StatusCode(400, "Bad Request: Invalid year");
movies = movies.Where(m => m.Year == y); movies = movies.Where(m => m.Year == y);
} }
if (sort != null) {
if (!IsValidSort(sort)) return StatusCode(400, "Bad Request: Invalid sort-type");
}
if (!IsValidPageNumber(pageNumber) || !IsValidPageSize(pageSize))
return StatusCode(400, "Bad Request: Invalid page-size or page-number");
var totalMovies = movies.Count(); var totalMovies = movies.Count();
var totalPages = Math.Ceiling((double)totalMovies / pageSize); var totalPages = Math.Ceiling((double)totalMovies / pageSize);
IEnumerable<MovieDB> resultSkip = movies.Skip(pageSize * (pageNumber - 1)); IEnumerable<MovieDB> resultSkip = movies.Skip(pageSize * (pageNumber - 1));
IEnumerable<MovieDB> resultTake = resultSkip.Take(pageSize); IEnumerable<MovieDB> resultTake = resultSkip.Take(pageSize);