From f293734490aeb6431c33c6d3b3c31321c8d3b12f Mon Sep 17 00:00:00 2001
From: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
Date: Wed, 6 Sep 2023 07:56:46 +0200
Subject: [PATCH] :recycle: componentization of objects

Co-authored-by: haraldnilsen <harald_998@hotmail.com>
---
 src/App.tsx                         | 58 +++++------------------------
 src/components/MovieModal/index.tsx | 45 ++++++++++++++++++++++
 src/components/MovieTable/index.tsx | 40 ++++++++++++++++++++
 src/components/index.ts             |  2 +
 src/types/movie.ts                  |  2 +
 5 files changed, 98 insertions(+), 49 deletions(-)
 create mode 100644 src/components/MovieModal/index.tsx
 create mode 100644 src/components/MovieTable/index.tsx

diff --git a/src/App.tsx b/src/App.tsx
index 5b32157..dc0fe44 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -1,7 +1,13 @@
 import { useEffect, useState } from 'react'
 import './App.css'
 import q from 'qjuul'
-import { MovieTableRow, MovieForm, Pagination } from './components'
+import {
+  MovieTableRow,
+  MovieForm,
+  Pagination,
+  MovieTable,
+  MovieModal,
+} from './components'
 import type { movieObject } from './types/movie'
 import Modal from 'react-modal'
 
@@ -87,36 +93,9 @@ function App() {
   return (
     <>
       <q.div className="flex flex-col justify-center items-center mx-auto w-2/4">
-        <Modal
-          className="p-6 bg-black rounded-lg outline-none" // styles for the modal container
-          overlayClassName="fixed inset-0 bg-black bg-opacity-50 flex items-center justify-center" // styles for the overlay
-          isOpen={modalOpen}
-          onRequestClose={() => setModalOpen(false)}
-        >
-          <q.div className="flex">
-            <q.img
-              className="h-44 max-w-sm mx-auto mb-4 rounded-md shadow"
-              src={modalMovie?.Poster}
-              alt={modalMovie?.Title}
-            />
-            <q.div className="flex flex-col px-10 pt-5">
-              <q.h1 className="text-xl font-bold mb-4">
-                {modalMovie?.Title}
-              </q.h1>
-              <q.p>Year: {modalMovie?.Year}</q.p>
-              <q.p>Type: {modalMovie?.Type}</q.p>
-              <q.a
-                className='"underline text-blue-500 hover:text-blue-700"'
-                href={`https://www.imdb.com/title/${modalMovie?.imdbID}`}
-              >
-                {`https://www.imdb.com/title/${modalMovie?.imdbID}`}
-              </q.a>
-            </q.div>
-          </q.div>
-        </Modal>
+        <MovieModal {...{ setModalOpen, modalMovie, modalOpen }} />
         <q.div className="flex flex-col w-full items-center">
           <q.h1 className="py-4">All movies</q.h1>
-
           <MovieForm
             {...{
               handleMovieSubmit,
@@ -135,26 +114,7 @@ function App() {
             )}
           </q.div>
           {!loading && movies ? (
-            <q.div className="w-full">
-              <q.table className="border-separate border-spacing-y-5 w-full">
-                <q.thead>
-                  <q.tr>
-                    <q.th>Poster</q.th>
-                    <q.th onClick={() => sortHandler('title')}>Title</q.th>
-                    <q.th onClick={() => sortHandler('year')}>Year</q.th>
-                  </q.tr>
-                </q.thead>
-                <q.tbody>
-                  {movies.map((movie: movieObject) => (
-                    <MovieTableRow
-                      movie={movie}
-                      key={movie.imdbID}
-                      onClick={() => handleModalOpen(movie)}
-                    />
-                  ))}
-                </q.tbody>
-              </q.table>
-            </q.div>
+            <MovieTable {...{ handleModalOpen, sortHandler, movies }} />
           ) : (
             <q.h1>Loading...</q.h1>
           )}
diff --git a/src/components/MovieModal/index.tsx b/src/components/MovieModal/index.tsx
new file mode 100644
index 0000000..75b6c4d
--- /dev/null
+++ b/src/components/MovieModal/index.tsx
@@ -0,0 +1,45 @@
+import type { modalMovieType } from '../../types/movie'
+import q from 'qjuul'
+import Modal from 'react-modal'
+
+interface MovieModalProps {
+  setModalOpen: (status: boolean) => void
+  modalMovie: modalMovieType
+  modalOpen: boolean
+}
+
+const MovieModal: React.FC<MovieModalProps> = ({
+  setModalOpen,
+  modalMovie,
+  modalOpen,
+}) => {
+  return (
+    <Modal
+      className="p-6 bg-black rounded-lg outline-none" // styles for the modal container
+      overlayClassName="fixed inset-0 bg-black bg-opacity-50 flex items-center justify-center" // styles for the overlay
+      isOpen={modalOpen}
+      onRequestClose={() => setModalOpen(false)}
+    >
+      <q.div className="flex">
+        <q.img
+          className="h-44 max-w-sm mx-auto mb-4 rounded-md shadow"
+          src={modalMovie?.Poster}
+          alt={modalMovie?.Title}
+        />
+        <q.div className="flex flex-col px-10 pt-5">
+          <q.h1 className="text-xl font-bold mb-4">{modalMovie?.Title}</q.h1>
+          <q.p>Year: {modalMovie?.Year}</q.p>
+          <q.p>Type: {modalMovie?.Type}</q.p>
+          <q.a
+            className='"underline text-blue-500 hover:text-blue-700"'
+            href={`https://www.imdb.com/title/${modalMovie?.imdbID}`}
+          >
+            {`https://www.imdb.com/title/${modalMovie?.imdbID}`}
+          </q.a>
+        </q.div>
+      </q.div>
+    </Modal>
+  )
+}
+
+export default MovieModal
diff --git a/src/components/MovieTable/index.tsx b/src/components/MovieTable/index.tsx
new file mode 100644
index 0000000..e769b5d
--- /dev/null
+++ b/src/components/MovieTable/index.tsx
@@ -0,0 +1,40 @@
+import type { movieObject } from '../../types/movie'
+import q from 'qjuul'
+import MovieTableRow from '../MovieTableRow'
+
+interface MovieTableProps {
+  handleModalOpen: (movie: movieObject) => void
+  sortHandler: (sortType: string) => void
+  movies: movieObject[]
+}
+
+const MovieTable: React.FC<MovieTableProps> = ({
+  handleModalOpen,
+  sortHandler,
+  movies,
+}) => {
+  return (
+    <q.div className="w-full">
+      <q.table className="border-separate border-spacing-y-5 w-full">
+        <q.thead>
+          <q.tr>
+            <q.th>Poster</q.th>
+            <q.th onClick={() => sortHandler('title')}>Title</q.th>
+            <q.th onClick={() => sortHandler('year')}>Year</q.th>
+          </q.tr>
+        </q.thead>
+        <q.tbody>
+          {movies.map((movie: movieObject) => (
+            <MovieTableRow
+              movie={movie}
+              key={movie.imdbID}
+              onClick={() => handleModalOpen(movie)}
+            />
+          ))}
+        </q.tbody>
+      </q.table>
+    </q.div>
+  )
+}
+
+export default MovieTable
diff --git a/src/components/index.ts b/src/components/index.ts
index 2860fa7..673fdd5 100644
--- a/src/components/index.ts
+++ b/src/components/index.ts
@@ -1,3 +1,5 @@
 export { default as Pagination } from './Pagination'
 export { default as MovieTableRow } from './MovieTableRow'
 export { default as MovieForm } from './MovieForm'
+export { default as MovieTable } from './MovieTable'
+export { default as MovieModal } from './MovieModal'
diff --git a/src/types/movie.ts b/src/types/movie.ts
index bba9dd2..25c5ae4 100644
--- a/src/types/movie.ts
+++ b/src/types/movie.ts
@@ -5,3 +5,5 @@ export type movieObject = {
   Year: string
   imdbID: string
 }
+
+export type modalMovieType = movieObject | null